fix guidance_scale value not equal to the value in comments#8941
Merged
yiyixuxu merged 2 commits intohuggingface:mainfrom Jul 25, 2024
efwfe:patch-1
Merged
fix guidance_scale value not equal to the value in comments#8941yiyixuxu merged 2 commits intohuggingface:mainfrom efwfe:patch-1
yiyixuxu merged 2 commits intohuggingface:mainfrom
efwfe:patch-1
Conversation
yiyixuxu
reviewed
Jul 23, 2024
| num_inference_steps: int = 28, | ||
| timesteps: List[int] = None, | ||
| guidance_scale: float = 7.0, | ||
| guidance_scale: float = 5.0, |
Collaborator
There was a problem hiding this comment.
thanks! can you change the comments (doc string) instead? we prefer not to change the default value because it will cause backward breaking
Contributor
Author
There was a problem hiding this comment.
Okay, already updated ~
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
DN6
approved these changes
Jul 25, 2024
sayakpaul
pushed a commit
that referenced
this pull request
Dec 23, 2024
fix guidance_scale value not equal with the value in comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix guidance_scale value not equal to the value in comments
default guidance_scale value:
comment guidance_scale value:
What does this PR do?
Fixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.